Skip navigation.
Home

Bad Architecture

I'm smrt'er.

Bad Architecture

This was sent in by the same anonymous user that submitted the code for I'm smrt. I guess the poor guy is still maintaining what appears to be some nightmare code. At least it gives us something to snicker at as we write our own nightmare code.

The story starts with our anonymous submitter having to dig through the code to figure out why some of the SQL queries were failing. What he found wasn't pretty...

That is some classy code...

Hall of Fame | Bad Architecture | Fugly Code | Wonky Code

Thanks to Andreas D. for sending this one in. This PHP code generates a heirachical menu in a not so nice way.

  • WTF #1 is for being very 'fugly' code. Nobody should indent with more than 4 spaces!
  • WTF #2 is the menu class. This class really has no point other than to hold two values which can be done with a simple array. See my example below.
  • WTF #3 is this $menu[$i][$j][0][0][0]->target. There's nothiing like a 5 dimensional array to make a really simple thing like menu generation really difficult.

Be sure to shield your eyes and don't look directly at this code...

XML feed